Rename TypeSignature::NullAry --> TypeSignature::Nullary and improve comments
#13817
+62
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 17, 2024
findepi
reviewed
Dec 17, 2024
findepi
approved these changes
Dec 17, 2024
| Coercible(Vec<TypeSignatureClass>), | ||
| /// The arguments will be coerced to a single type based on the comparison rules. | ||
| /// For example, i32 and i64 has coerced type Int64. | ||
| /// One or more arguments that can be "compared" |
There was a problem hiding this comment.
Agreed -- this can be made better. I will attempt a follow up
There was a problem hiding this comment.
| /// | ||
| /// Note: | ||
| /// - If compares with numeric and string, numeric is preferred for numeric string cases. For example, nullif('2', 1) has coerced types Int64. | ||
| /// - If compares with numeric and string, numeric is preferred for numeric string cases. For example, `nullif('2', 1)` has coerced types `Int64`. |
There was a problem hiding this comment.
is the reader expected to know/assume that nullif uses signature "Comparable"?
There was a problem hiding this comment.
actual example direct reader to understand this easily
jayzhan211
approved these changes
Dec 18, 2024
|
Thanks @alamb |
findepi
approved these changes
Dec 19, 2024
Comment on lines
+103
to
+104
| /// A function such as `concat` is `Variadic(vec![DataType::Utf8, | ||
| /// DataType::LargeUtf8])` |
There was a problem hiding this comment.
nit:
Maybe it would be more readable to go without DataType: for type names?
|
Thank you for the reviews @jayzhan211 and @findepi -- I think this PR is an improvement over what is on main (though there is still more improvement to be had). Thus merging it in and will work on additional clarifications as a follow up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Signature::nullaryin 44.0.0 easier / less confusing #13763Rationale for this change
While I was making that change I noticed that the
TypeSignaturedocumentation could be improved as well so I did it at the same timeWhat changes are included in this PR?
TypeSignature::NullAry-->TypeSignature::NullaryAre these changes tested?
By CI
Are there any user-facing changes?
The name of an enum has changed, but this has not yet been released, so it isn't a user visible change in my mind